Can someone please correct my code for the TI-83 BASIC programming language? Whenever you play my fighting game, after a while, it will say Error, memory.


Code:

Common problem with that is you are exiting loops without letting the code encounter the proper End commands.

I shall give it a look and see what I can tell needs fixing tho..

Edit

Alright, a quick look shows you going out of a While 1 loop repeatedly with Goto.

This is bad form, and causes your problem you are seeing.

Possible solutions are to either get rid of your while loop, or get rid of the Goto/Lbl commands.

Getting rid of the while would probably be shorter, but what would be the best way to do so?

Somebody move this to the TI-BASIC subforum plzkthxbye

Done.

And actually, continuing with Goto/Lbl is going to be your worst thought, you might want to rethink going with While loops. You can utilize them in much the same way as you can with Lbl and Goto.

The reason I say this is because you have Goto commands coming before End statements. Everytime the calculator comes across a Then or loop command, it logs it within a special part of memory. That eventually fills up your available RAM and causes the problem you are facing.

Thanks, that makes sense. I will rework it.

I recommend against the fake loading screen as it's not actually loading anything and just takes up time.

The problem is all the places that you are performing a Goto inside of an If...(else)...End block.

Corrected and somewhat-optimized code:

Code:

Thank you, this code works perfectly so far. I now know how to do this for the future.

Whew, I'm glad to hear that; I was a tad concerned I hadn't preserved your functionality as far as which things made you get hit or blocked etc. I hope you'll keep asking us questions and consulting for BASIC tips and optimizations. Did you notice the places I stripped off closing parentheses or quotes, for example? And where 0->VAR became DelVar VAR?

Yeah, you got rid of the quotes to decrease size and delvar is just another way to do it.

Precisely. Once you start to feel more confident with TI-BASIC, you should check out the 1337 BASIC Guide that I wrote together with the eminent Jon "JPez" Pezzino.

http://www.ticalc.org/archives/files/fileinfo/369/36993.html

So, if I'm reading this right, you can't have a Goto inside an If/Then...End block. For example, this would be wrong and would eventually cause ERR:MEMORY:

Code:


Would you instead put this?:

Code:

No, you wouldn't. A Goto inside any programming control structure that takes End, such as Then, For, While, and Repeat, causes a memory leak. The only way to not create a memory leak would be:


Code:

Ok I think i know what you're saying, but I don't quite know how to work around it. This is the program I'm stuck on. It's a countdown timer:

Code:

Not true. There is another way. If the label is only ever called from a place with the same number of End statements required, you can stop the leak:

[code=TI Basic]While 1
If getKey=21
Then
0→A
Goto LB
End
End
Lbl LB
End:End // Fixes the leak
// Put your code here[/code]

That's technically accurate, but I was omitting that for the sake of simplicity, since it takes a fair amount of care to get that right.

Fair enough.
However, omitting it does not fix his code.

Here is the original version, fixed (Untested)

Code:

But I already fixed his code, above, and to be much better and shorter than that.



Let me know if this works:
Code:

I know that he fixed it, I was just demonstrating the concept.